<html><head><meta name="color-scheme" content="light dark"></head><body><pre style="word-wrap: break-word; white-space: pre-wrap;">
From: Neil Brown &lt;neilb@cse.unsw.edu.au&gt;

Avoid unlock-without-lock problem on error path in nfsd4_setclientid_confirm

Signed-off-by: Neil Brown &lt;neilb@cse.unsw.edu.au&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
---

 25-akpm/fs/nfsd/nfs4state.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN fs/nfsd/nfs4state.c~nfsd4_setclientid_confirm-locking-fix fs/nfsd/nfs4state.c
--- 25/fs/nfsd/nfs4state.c~nfsd4_setclientid_confirm-locking-fix	2005-01-05 20:43:09.848823144 -0800
+++ 25-akpm/fs/nfsd/nfs4state.c	2005-01-05 20:43:09.854822232 -0800
@@ -802,9 +802,8 @@ nfsd4_setclientid_confirm(struct svc_rqs
 	clientid_t * clid = &amp;setclientid_confirm-&gt;sc_clientid;
 	int status;
 
-	status = nfserr_stale_clientid;
 	if (STALE_CLIENTID(clid))
-		goto out;
+		return nfserr_stale_clientid;
 	/* 
 	 * XXX The Duplicate Request Cache (DRC) has been checked (??)
 	 * We get here on a DRC miss.
_
</pre></body></html>